On Wed, 27 Jul 2022 12:06:51 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> The DLL should be built no matter what `BUILD_CRYPTO` is.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   indentation change

Looks good.

Minor style nit. We like to have 2 space indent for logical blocks and 4 space 
for continuation in the makefiles. See 
https://openjdk.org/groups/build/doc/code-conventions.html. So in this case, 
please remove 2 spaces from everything in the new ifeq block.

-------------

Marked as reviewed by erikj (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9647

Reply via email to