On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel <hsei...@openjdk.org> wrote:
> Please review this fix for JDK-8285792. The fix removes print statements > from check_signal_handler() so that it doesn't print all the handlers every > time it finds one that is modified. Instead, it returns true if the handler > is modified, false otherwise. Its caller, user_handler(), then prints all > the handlers just once even if multiple signal handlers were modified. > > The fix also adds a check for VMError::crash_handler_adress() to > check_signal_handler() to prevent it from being treated as a signal handler > modification. > > The fix was tested with Mach5 tiers 1-2 on Linux and Mac OS and Mach 5 tiers > 3-5 on Linux x64. The regression test is excluded on Windows. > > Thanks, Harold This pull request has now been integrated. Changeset: 48b77a69 Author: Harold Seigel <hsei...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/48b77a69697adb9967e58a18e1f248afb30e1b26 Stats: 171 lines in 4 files changed: 146 ins; 4 del; 21 mod 8285792: Posix signal handler modification checking issues. Reviewed-by: dholmes, erikj ------------- PR: https://git.openjdk.org/jdk/pull/9631
