On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth <lkori...@openjdk.org> wrote:

> One can select a testcase by ID when running a jtreg test case directly from 
> jtreg (using the testcase.java#testID syntax). However, this has not been 
> possible to do when launching jtreg indirectly from make.
> 
> This fix attempts to address this issue. I have not tested this thoroughly 
> yet, I wanted to show the code to get feedback first. The idea is to *not* 
> emulated destructive imperative assignments through the use of eval. I 
> instead try to handle it in a functional style without reassigning variables. 
> I have tried to make the change as small as possible.
> 
> I am not used to change the build system, so I would appreciate thorough 
> review.
> 
> `IfAppend` and `IfPrepend` are general purpose functions. If similar 
> functions exists elsewhere inside the code base or in make itself I should 
> probably use those instead. If they do not exist, they might be useful 
> elsewhere and maybe should be placed in a common make file instead of the 
> RunTests.gmk file.

This pull request has now been integrated.

Changeset: c59f9b37
Author:    Leo Korinth <lkori...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/c59f9b374b4497ab385675b0019c3647e6cddbbb
Stats:     52 lines in 2 files changed: 26 ins; 21 del; 5 mod

8287828: Fix so that one can select jtreg test case by ID from make

Reviewed-by: erikj, iklam, ihse

-------------

PR: https://git.openjdk.org/jdk/pull/9028

Reply via email to