On Wed, 24 Aug 2022 08:08:51 GMT, Yadong Wang <yadongw...@openjdk.org> wrote:

>> Sacha Coppey has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add a comments for the change in deoptimization.hpp
>
> src/hotspot/cpu/riscv/jvmciCodeInstaller_riscv.cpp line 119:
> 
>> 117:     }
>> 118:     jint vectorRegisterNumber = floatRegisterNumber - 
>> FloatRegisterImpl::number_of_registers;
>> 119:     if (vectorRegisterNumber >= 0 && vectorRegisterNumber - 
>> VectorRegisterImpl::number_of_registers) {
> 
> Maybe you want to check if `vectorRegisterNumber < 
> VectorRegisterImpl::number_of_registers`.

Indeed, it is incorrect. In fact, since I removed the vector registers for now, 
I should just remove this part.

-------------

PR: https://git.openjdk.org/jdk/pull/9587

Reply via email to