On Thu, 25 Aug 2022 10:44:32 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change to the testing documentation which > adds a note about failure handlers in jtreg? This addresses > https://bugs.openjdk.org/browse/JDK-8292911. > > Recently, there have been users who have been prompted for sudo password when > running jtreg tests locally and those tests running into failures. This is > because one of the commands that gets executed by the jtreg failure handler > uses sudo (the `sudo dmesg` command on macos). > > This commit updates the `testing.md` to explain what the failure handler does > and also mentions the configuration that can be used to disable the failure > handler. This commit doesn't specify how to configure the `sudoers` file if > the user still wants to allow the failure handlers to run, because I thought > that would be outside the scope of this documentation. > > I attempted to auto generate the `testing.html` from the changes to > `testing.md` using the `make update-build-docs` command, but that generated a > lot of unnecessary diffs not just in `testing.html` but other html files in > the `doc` directory. So, as suggested in a different PR which involved > updates to these files, I manually added the section to the `testing.html` > too. This pull request has now been integrated. Changeset: 99cab6a6 Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/99cab6a68e16b6e39f82a7a4aa98a551d1df292b Stats: 28 lines in 2 files changed: 28 ins; 0 del; 0 mod 8292911: Add a note about jtreg failure handlers in the testing doc Reviewed-by: lancea, erikj, jjg ------------- PR: https://git.openjdk.org/jdk/pull/10021
