On Fri, 9 Sep 2022 11:51:55 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> I think this looks good now. But this is apparently tricky business, with the > three of us taking turns of thinking wrongly about this. :-) Let's hear what > Erik has to say, too. > > Have you verified that it still does the correct things in cases like: > > 1. only non-visible changes in individual files > 2. visible-changes in individual files > 3. changes in a dependent module > 4. changes in javac setup, like an added Xlint option > 5. and some combinations, where I think 1+3 is most relevant > > ? This is indeed tricky business, and I thank you for hanging in there while we figure it out. It's certainly much better to discover and rethink at the review stage than in followup bugs. I think this solution is good, pending confirmation that you tried all the cases Magnus listed. ------------- PR: https://git.openjdk.org/jdk/pull/10104
