On Thu, 15 Sep 2022 16:41:42 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Reworked doc text
>
> make/autoconf/jdk-options.m4 line 750:
> 
>> 748:         ENABLED_DEFAULT: true,
>> 749:         CHECKING_MSG: [for macosx code signing mode],
>> 750:         DESC: [set the macosx code signing mode (hardened, debug, auto)]
> 
> I think UTIL_ARG_WITH lists all VALID_VALUES in the help text for literal 
> options, so listing them yourself is probably making it a duplicate in the 
> help text. (It should do, at least, but I'm not 100% sure, so please verify)

I was hoping it would, but as it didn't, I listed them myself. It only shows 
the default choice. This is what it currently looks like with the proposed 
patch:

  --with-macosx-codesign  set the macosx code signing mode (hardened, debug, 
auto) [auto]

-------------

PR: https://git.openjdk.org/jdk/pull/10275

Reply via email to