On Fri, 23 Sep 2022 12:26:06 GMT, Aleksey Shipilev <[email protected]> wrote:
> Ah, I realized that my current CI scripts would fail with duplicate `-report` > after this fix: > > ``` > $ time CONF=linux-x86_64-server-release make run-test > TEST=gc/epsilon/TestHelloWorld.java JTREG="OPTIONS=-report:executed" > > Running test 'jtreg:test/hotspot/jtreg/gc/epsilon/TestHelloWorld.java' > Error: Duplicate option: -report > ``` > > Let me see if I can sense the user override... So it seems to make little sense in trying to yank `-report` from the current `OPTIONS`. We don't do generally this, and conflicts through `OPTIONS` would generally fail -- for example, if you try to do `JTREG="OPTIONS=-status:pass"` the test would fail with "Duplicate -status:". Instead, I introduced `JTREG` `REPORT` option to pick the override if any user needs it. This also allows to get the old behavior with `JTREG="REPORT=all-executed"` if there are regressions. It also allows testing with `JTREG="REPORT=files"` once jtreg supports it. ------------- PR: https://git.openjdk.org/jdk/pull/10405
