On Wed, 5 Oct 2022 13:46:23 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> I am not completely sure all `misleading-indentation` warnings are fixed in >> Awt2d, this would require some more testing. I'd defer that to #10453. > > Awt2dLibraries.gmk in https://github.com/openjdk/jdk/pull/10453 seems more > about clang if I'm not mistaken, while this change is about gcc. > The JDK successfully builds on several platforms with this change. > > What else could go wrong? I'm asking because I'm not a build engineering > expert at all. This could fail the build on some toolchains. Cleanliness and least surprise: this PR changes the particular files, and so it should remove the warnings for those specific files. ------------- PR: https://git.openjdk.org/jdk/pull/10487
