On Wed, 12 Oct 2022 13:42:39 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/hotspot/lib/CompileJvm.gmk line 92: >> >>> 90: >>> 91: DISABLED_WARNINGS_clang := ignored-qualifiers sometimes-uninitialized \ >>> 92: missing-braces delete-non-abstract-non-virtual-dtor unknown-pragmas >> >> Shouldn't shift-negative-value be in the clang list too? > > Well, there is currently no instance of clang complaining about this. This > could be due to: > > * This warning does not really exist on clang > * Or it is not enabled by our current clang flags > * Or the code which triggers the warning in gcc is not reached by clang > * Or clang is smarter than gcc and can determine that the usage is ok after > all > * Or clang is dumber than gcc and does not even see that there could have > been a problem... > > ... > > I'm kind of reluctant to add warnings to this list that have not occurred for > real. My suggestion is that we add it here if we ever see it making incorrect > claims. Ok? I'm worried about someone encountering it and uglifying code to work around it. OTOH, I don't know why we're not seeing this warning with clang, as there is shared code that should trigger it (and does for gcc). So I'm okay with it as is. ------------- PR: https://git.openjdk.org/jdk/pull/10414
