On Mon, 17 Oct 2022 14:31:46 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Some external libraries required by native code are linked via linker >> comments embedded in pragmas. Searching for which libraries are linked can >> then become frustrating and confusing since they may be included in an >> obscure place, and for all relevant compilers there is no difference between >> specifying them from make and in a source file. The easiest solution is to >> just always link them from make and remove any source level linkage. > > Julian Waters has updated the pull request incrementally with five additional > commits since the last revision: > > - Update WinSysInfo.cpp > - Update WinApp.cpp > - Update MsiUtils.cpp > - Update MsiDb.cpp > - Update MsiCA.cpp Thanks all for the reviews, I placed comments where the pragmas used to be detailing the library required by the source file to address David's concerns ------------- PR: https://git.openjdk.org/jdk/pull/10633
