On Wed, 2 Nov 2022 15:31:15 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into permissive >> - Merge remote-tracking branch 'upstream/master' into permissive >> - Format >> - Keep docs up to date >> - New --enable-conforming-compilation option > > make/autoconf/spec.gmk.in line 333: > >> 331: ENABLE_HEADLESS_ONLY := @ENABLE_HEADLESS_ONLY@ >> 332: >> 333: ENABLE_CONFORMING_COMPILATION := @ENABLE_CONFORMING_COMPILATION@ > > You don't need to export this in spec.gmk, since it is only checked in the > configure script. We try hard to only export here what is strictly necessary > for use by makefiles. If you will ever need it in the future, please add it > as an export here at that time. Alright, will do ------------- PR: https://git.openjdk.org/jdk/pull/10912
