> One of the more prevalent issues is that files in src/hotspot/share/include > are not properly sorted. There has been some discussion that that was done on > purpose, but it just adds another exception to the include rules that don't > have any practical purposes, IMHO. It also goes against our written style > guide around include files. One argument why it was OK have the files in > include/ pushed up to the top of the sorted block, was that the file was > included without specifying a directory. That's an argument that contradicts > how we treat platform-dependent files, which (unfortunately) often also are > specified without a prefixed directory. To remove this special case, I've > removed the extraneous make file entry to have src/hotspot/share/include in > the set of directories to search for headers when compiling HotSpot. Now all > the header files in src/hotspot/share/include gets included by specifying the > path from src/hotspot/share, just like the other platform-independent headers > in HotSpot . > > This RFE splits out the 'include/' changes from #11108 / JDK-8296886, so that > those changes can be discussed separately.
Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision: Revert make file changes ------------- Changes: - all: https://git.openjdk.org/jdk/pull/11133/files - new: https://git.openjdk.org/jdk/pull/11133/files/a4a479ed..92cba2ea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11133&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11133&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/11133.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11133/head:pull/11133 PR: https://git.openjdk.org/jdk/pull/11133
