On Sat, 12 Nov 2022 15:23:41 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> With this PR I'd like to make it easier to use dedicated installations of >> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode >> globally via `xcode-select`. >> >> I propose adding a new configure flag `--with-xcode-path` that takes the >> path to an Xcode installation. If the option is set, this path is expanded >> to a valid `TOOLCHAIN_PATH`. >> >> Furthermore, I fix detection of xcodebuild and correctly setting the sysroot >> from the toolchain by moving `AC_SUBST(TOOLCHAIN_PATH)` before calling >> `BASIC_SETUP_XCODE_SYSROOT` and honoring `TOOLCHAIN_PATH` in >> BASIC_SETUP_XCODE_SYSROOT in the case when no devkit is specified. As I see >> it, this is a viable fix, even if not introducing `--with-xcode-path`. > > Christoph Langer has refreshed the contents of this pull request, and > previous commits have been removed. The incremental views will show > differences compared to the previous content of the PR. The pull request > contains one new commit since the last revision: > > Improve options for xcode toolchain Thanks for the review, I took over your suggestion. Will integrate shortly. ------------- PR: https://git.openjdk.org/jdk/pull/11113
