On Fri, 18 Nov 2022 12:06:39 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> With this PR I'd like to make it easier to use dedicated installations of >> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode >> globally via `xcode-select`. >> >> I propose adding a new configure flag `--with-xcode-path` that takes the >> path to an Xcode installation. If the option is set, this path is expanded >> to a valid `TOOLCHAIN_PATH`. >> >> Furthermore, I fix detection of xcodebuild and correctly setting the sysroot >> from the toolchain by moving `AC_SUBST(TOOLCHAIN_PATH)` before calling >> `BASIC_SETUP_XCODE_SYSROOT` and honoring `TOOLCHAIN_PATH` in >> `BASIC_SETUP_XCODE_SYSROOT` in the case when no devkit is specified. As I >> see it, this is a viable fix, even if not introducing `--with-xcode-path`. > > Christoph Langer has updated the pull request incrementally with one > additional commit since the last revision: > > Fix enumeration for html Hm, the changes you made to the markdown file does not result in any changes in the generated html file. :( I fixed it by adding an additional empty line in the markdown file. The commit including both these fixes are here: https://github.com/magicus/jdk/commit/2844de1591ee8246dfb0fb5d19664b9db1d68c3a ------------- PR: https://git.openjdk.org/jdk/pull/11113
