On Tue, 13 Dec 2022 17:58:58 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Undo changes to autoconf-config.guess > > make/autoconf/build-aux/config.guess line 35: > >> 33: OUT=`. $DIR/autoconf-config.guess 2> "$TMPFILE"` >> 34: ERR=`cat "$TMPFILE"` >> 35: rm "$TMPFILE" > > I don't like relying on mktemp and the global temp directory in our build > scripts. Unfortunately catching both stdout and stderr into variables isn't > really possible in shell. However, running `autoconf-config.guess` should be > fairly deterministic and quick, so I would suggest just ignoring stderr here: > > Suggestion: > > OUT=`. $DIR/autoconf-config.guess 2> /dev/null` Makes sense. > make/autoconf/build-aux/config.guess line 63: > >> 61: >> 62: if [ "x$OUT" = x ]; then >> 63: echo $ERR >&2 > > And just rerun the script if we need to print the error. > Suggestion: > > # Run autoconf-config.guess again to get the error message. > . $DIR/autoconf-config.guess > /dev/null Done. ------------- PR: https://git.openjdk.org/jdk20/pull/15
