On Thu, 15 Dec 2022 14:15:29 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options that still use AC_ARG_WITH in jdk-version.m4. >> They are out of the scope of this commit, which aims only to rework the >> previous integrated commits mentioned above. > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Unbreak GHA (When debug printing, it is often useful to include a literal marker to know your statement has been printed. I usually also often test for extra whitespaces by printing e.g. `echo USER is :$USER:`.) I'm a bit surprised we did not run into this as an issue before..? Apparently we have handled properly an empty $USER prior to this PR. Maybe you should just add a fallback that if we're doing an adhoc build and $USER is empty after stripping, it should just be set to `duke` as default. ------------- PR: https://git.openjdk.org/jdk/pull/11020
