On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> Please review this patch that removes unnecessary exports from libawt and > libfreetype. > > Verified that: > - mach5 client libs tests pass > - both release and debug builds finish successfully > > Did not verify the other issues reported in the linked JBS ticket. yes, I did build `--with-freetype=bundled`, and I compared the results of `readelf -s` between the system libfreetype and the one produced by the build. After these changes, all of the bundled exports were present in system library. The following exports of the system library were absent in the bundled one: FTC_CMapCache_Lookup FTC_CMapCache_New FTC_ImageCache_L[...] FTC_ImageCache_Lookup FTC_ImageCache_New FTC_Manager_Done FTC_Manager_Look[...] FTC_Manager_Look[...] FTC_Manager_New FTC_Manager_Remo[...] FTC_Manager_Reset FTC_Node_Unref FTC_SBitCache_Lo[...] FTC_SBitCache_Lookup FTC_SBitCache_New FT_ClassicKern_Free FT_ClassicKern_V[...] FT_Error_String FT_Get_BDF_Charset_ID FT_Get_BDF_Property FT_Get_PFR_Advance FT_Get_PFR_Kerning FT_Get_PFR_Metrics FT_Get_WinFNT_Header FT_Gzip_Uncompress FT_OpenType_Free FT_OpenType_Validate FT_Palette_Data_Get FT_Palette_Select FT_Palette_Set_F[...] FT_Stream_OpenBzip2 FT_Stream_OpenGzip FT_Stream_OpenLZW FT_TrueTypeGX_Free FT_TrueTypeGX_Va[...] These exports were absent even before my changes, so I believe we should be fine here. ------------- PR: https://git.openjdk.org/jdk/pull/11742
