On Sun, 25 Dec 2022 06:54:16 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> MSYS2 should be more appropriately installed into the runner's temporary >> directory rather than inside the newly checked out repository containing all >> the JDK's source code, as doing so may interfere with the build process and >> cause weird corner cases in the submitted actions workflow > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'openjdk:master' into patch-2 > - Formatting > - Directory reference > - Avoid installing MSYS2 in the JDK's source directory Looks good to me. But you should wait for approval of somebody from the build group. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.org/jdk/pull/11782