On Wed, 4 Jan 2023 06:22:11 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Exclude more zapping when ASan is in use >> >> Signed-off-by: Justin King <jck...@google.com> > > This doesn't look "too terrible", but I can't comment on the actual poisoning > strategies. > > Cheers. > Forcing 2 reviewers to ensure @dholmes-ora can chime in before moving forward. Well I won't be able to Review as not familiar enough with the code, so you'll need a second reviewer anyway. I don't hate this to the point of outright rejecting it but I do have general concerns about whether we should be directly supporting such tools in our codebase, and if we should whether these are the right tools. So I've asked other hotspot folk to chime in. ------------- PR: https://git.openjdk.org/jdk/pull/11702
