On Tue, 10 Jan 2023 20:48:55 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:

> This change makes native output files be only printed when building with 
> LOG=info, to make the build not have so many pages of output.
> Tested with GHA and locally (tbd)

I'm sorry, but I don't think this is the right solution here. I agree that the 
log level needs to be altered in some way when compiling the tests, as there 
are so many of them, but this removes logging at the default level for all 
native targets. I also think it's inconsistent if the "Creating ..." log 
message is on info while the "Updating ..." of the same thing is still on warn.

I think a better solution would be to give SetupNativeCompilation a parameter 
or two that controls log level, and that the SetupTestCompilation macro could 
use that to lower the level for test compilations, while probably also adding a 
meta log message for all the tests it's building to replace the individual log 
messages on level warn.

-------------

PR: https://git.openjdk.org/jdk/pull/11930

Reply via email to