On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> MSYS2 should be more appropriately installed into the runner's tool cache >> rather than inside the newly checked out repository containing all the JDK's >> source code, as doing so may interfere with the build process and cause >> weird corner cases in the submitted actions workflow > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - Merge branch 'openjdk:master' into patch-2 > - Install in RUNNER_TOOL_CACHE > - Merge branch 'openjdk:master' into patch-2 > - Merge branch 'openjdk:master' into patch-2 > - Merge branch 'openjdk:master' into patch-2 > - Merge branch 'openjdk:master' into patch-2 > - Merge branch 'openjdk:master' into patch-2 > - Formatting > - Directory reference > - Avoid installing MSYS2 in the JDK's source directory Marked as reviewed by ihse (Reviewer). Hi, I'm back today from vacation and is trying to catch up, so your timing was excellent. ;) This looks good. I have seen your attempt at fighting with GHA in #11020, and I am impressed with your patience and stubborness. :-) I'm glad it panned out in a solution. I deliberately designed the GHA code so that each action that installs some part returns the path. This means it should be trivial to move where gtest, jtreg etc is installed as well. I did not specifically study the different storage roots provided by GHA, so it might very well be the case that all of these should be stored in the tool cache as well. If this is your conclusion, feel free to open a new PR where you update them in the same way. ------------- PR: https://git.openjdk.org/jdk/pull/11782
