On Thu, 12 Jan 2023 17:39:05 GMT, Vicente Romero <[email protected]> wrote:
>> Archie L. Cobbs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Use the more appropriate Type comparison method Types.isSameType().
>> - Add some more comments to clarify how the analysis works.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
> line 200:
>
>> 198: //
>> 199:
>> 200: public void analyzeTree(Env<AttrContext> env) {
>
> nit: this method could be removed in favor of the overloaded version below
Thanks - will fix.
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
> line 204:
>
>> 202: }
>> 203:
>> 204: public void analyzeTree(Env<AttrContext> env, JCTree tree) {
>
> nit: `env` parameter doesn't seem to be used could be dropped I think
Thanks - will fix.
-------------
PR: https://git.openjdk.org/jdk/pull/11874
