On Fri, 13 Jan 2023 11:08:33 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Perhaps my confusion might come from the name `this-escape` of the lint >> warning - which seems overpromising in this respect. But I looked at the >> description of the lint warning using `javac --help-lint` and I got this: >> >> >> this-escape Warn when a constructor invokes a method that could >> be overriden in a subclass; >> >> >> Which indeed aligns well with what this PR is doing. So that's ok. > > Something seems to be up with the lint description for this-escape - compare > this: > > > serial Warn about Serializable classes that do not have a > serialVersionUID field. > Also warn about other suspect declarations in > Serializable and Externalizable classes and interfaces. > > with this: > > > this-escape Warn when a constructor invokes a method that could be > overriden in a subclass; > such a method would execute before the subclass constructor completes its > initialization. > > > Indentation seems to be missing, which causes readability issues in the > `--help-lint` output. > I guess I was confused because, while subclasses are a particularly sneaky > case where uninitialized values can show up, the above leak seems potentially > dangerous as well... Yes - and this very question did come up in the discussions around this warning (see amber-dev). The decision was to go with drawing the "warning boundary" at the compilation unit. The reasoning is that (a) this aligns with the compiler's "knowledge boundary", i.e., we can know for sure from code inspection, and also (b) focuses the warning on the particularly pernicious aspect of these bugs, which is that they arise from the non-obvious interaction among two or more files - even when looking at any single one of those files, there doesn't seem to be any apparent problem. In other words, we decided "not to try to save any single source code from itself". But I think it's still an interesting question. Maybe experience will provide more guidance over time. ------------- PR: https://git.openjdk.org/jdk/pull/11874
