On Tue, 17 Jan 2023 04:13:22 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> There are several configure settings that should have different default >> values depending on if configure is run as part of a CI build, or a local >> developer. >> >> We should have a `--with-build-env=ci/dev` argument that lets you chose such >> build environment. Furthermore, configure should look for the industry >> standard "CI" environment variable to determine if it is running in a CI >> environment, and if so, select the ci build env as default. (This is >> supported e.g. by GHA). >> >> Most prominently is the jtreg failure handler, which will halt with a sudo >> prompt unless running on a properly configured CI machine on macOS. There is >> no reason to run the failure handler at all unless you are running on a CI >> machine, so disabling the failure handler by default for developer build >> environments will fix this problem. > >> There are several configure settings that should have different default >> values depending on if configure is run as part of a CI build, or a local >> developer. > > This change only seems to deal with the jtreg failure handler, are there more > settings to come? @dholmes-ora I hope to be able to add more settings, yes. But I think that needs to happen in a dialogue with developers, to get sensible and useful default values. So I'd rather push this as a starting point for a framework to differentiate between CI and dev environment, and then we can add additional setting default changes one by one. ------------- PR: https://git.openjdk.org/jdk/pull/11991
