On Mon, 23 Jan 2023 19:34:42 GMT, Archie L. Cobbs <d...@openjdk.org> wrote:
> [The CSR](https://bugs.openjdk.org/browse/JDK-8299995) also needs a review > from a compiler-dev engineer as well if anyone is interested... thanks. some comments on the CSR: - I think the value for field `Compatibility Risk` could be low, instead of medium. Even for code that uses -Xlint:all users will mostly see more warnings, they can change this setting or add @SW annotations to the code if available - The `Implementation` section I think could be moved to a JIRA comment - I think that the `Specification` section has text that probably is describing the solution, to me the specification section should start in this line: `Changes to the module-info.java Javadoc for module jdk.compiler:` ------------- PR: https://git.openjdk.org/jdk/pull/11874