On Thu, 26 Jan 2023 04:05:37 GMT, Julian Waters <jwat...@openjdk.org> wrote:
> Links to debuginfo files should only be made after strip is run, as doing so > before can cause strip to wreck the embedded link and make the executable > entirely un-executable in certain strange cases. It's safer to always just > make the link after strip is called regardless Otherwise, it looks good! make/common/NativeCompilation.gmk line 1067: > 1065: $1_CREATE_DEBUGINFO_CMDS := \ > 1066: $$($1_OBJCOPY) --only-keep-debug $$($1_TARGET) > $$($1_DEBUGINFO_FILES) $$(NEWLINE) > 1067: $1_CREATE_DEBUGINFO_LINK_CMDS := $(CD) $$($1_SYMBOLS_DIR) && \ Maybe add a comment along the lines of "debuglink needs to be done after stripping" ------------- Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.org/jdk/pull/12209
