On Thu, 2 Feb 2023 06:01:04 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Support CDS
>>
>> Signed-off-by: Justin King <jck...@google.com>
>
> src/hotspot/share/runtime/arguments.cpp line 3979:
>
>> 3977: // LSAN relies on pointers to be natively aligned. Using compressed
>> class pointers breaks this
>> 3978: // expectation and results in nondeterministic leak reports.
>> 3979: if (FLAG_SET_CMDLINE(UseCompressedOops, false) != JVMFlag::SUCCESS) {
>
> This positioning doesn't look right. There are a number of inter-dependencies
> on the compressed oops flags and I don't think you can just turn them off
> here. Surely `Arguments::set_use_compressed_oops()` is where this needs to be
> done?
Not sure FLAG_SET_CMDLINE is right here either (but flag setting is very
confusing).
-------------
PR: https://git.openjdk.org/jdk/pull/12229
