On Fri, 3 Feb 2023 17:22:32 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/classes/jdk/internal/classfile/TypeAnnotation.java line
> 75:
>
>> 73: * The kind of target on which the annotation appears.
>> 74: */
>> 75: public enum TargetType {
>
> My IDE says this enum is not being used. I tend to believe it, since the
> TargetInfo sealed interface also seems to model the same thing?
There is only one TargetInfo for all TargetTypes, so instead of 22
sub-interfaces of TargetInfo, the instance of TargetType enum is hold in
TargetInfo.
> src/java.base/share/classes/jdk/internal/classfile/TypeAnnotation.java line
> 577:
>
>> 575:
>> 576: /**
>> 577: * type_path.path.
>
> The javadoc in this class seems off
will fix, thanks
-------------
PR: https://git.openjdk.org/jdk/pull/10982
