On Mon, 6 Feb 2023 12:35:16 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 . > > I have seen C4819 warning in harfbuzz files on Windows (CP932: Japanese > locale) > > > d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1): > error C2220: 次の警告はエラーとして処理されます > d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1): > warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを > Unicode 形式で保存してください。 > > > I added C4819 to DISABLED_WARNINGS_microsoft for libfontmanager and for > libfreetype because they are 3rd-party libraries. I notice you didn't bother telling folks what this warning is It is https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4819?view=msvc-170 "The file contains a character that cannot be represented in the current code page (number)." JDK does not support being built in arbitrary locales. And the warning comes from hb.hh at some line you don't reveal so I can't tell if its in a comment or something more critical, and then since its in a central header file I can't tell if its the only such warning or not. This fix is rejected. Build in an English locale. ------------- PR: https://git.openjdk.org/jdk/pull/12437
