On Tue, 7 Feb 2023 16:04:07 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - javadoc fixes >> - obsolete identifiers and unused imports cleanup >> - TypeAnnotation.TypePathComponent cleanup > > src/java.base/share/classes/jdk/internal/classfile/attribute/ModuleExportInfo.java > line 107: > >> 105: * @param exportsTo the modules to which this package is exported >> 106: */ >> 107: static ModuleExportInfo of(PackageEntry exports, > > (Here and elsewhere) - should there be factories also taking a PackageDesc > (which seems to be an extension of the ClassDesc API, but for packages) ? yes, they are missing, I'm working on it. ------------- PR: https://git.openjdk.org/jdk/pull/10982