On Thu, 9 Feb 2023 15:21:42 GMT, Amit Kumar <d...@openjdk.org> wrote:
> We don't need NUM_LCPU, it's just a small code change which removes this > variable. I've tested it on AIX and cores are detected successfully with > changes. > @backwaterred please take look at it. > Suggestions are welcomed :) I wanted to point out these changes are semantically different in the error case. If we don't get the output we expect from lparstat we potentially overwrite the NUM_CORES var with the empty string. Previously, the code protected against this by testing if the result stored in the temp variable was non-empty before committing to them. Checking the [documentation](https://www.ibm.com/docs/en/aix/7.2?topic=l-lparstat-command) for AIX 7.1-7.3, it seems like the syntax is stable, so removing this check seems reasonable to me. ------------- Marked as reviewed by tsteele (Committer). PR: https://git.openjdk.org/jdk/pull/12494
