On Thu, 16 Feb 2023 16:08:55 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Rich DiCroce has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Limit line length to 80-ish characters
>
> src/java.base/windows/native/libnet/NetworkInterface.c line 72:
>
>> 70: return FALSE;
>> 71: }
>> 72: if (GetAnycastIpAddressTable(addrFamily, anyAddrs) != NO_ERROR) {
>
> Were the anycast addresses covered by the existing code, or is this a
> functional change?
For the IPv6 code, this should be the same as before. See getAddrsFromAdapter
in the original code, which enumerates the unicast addresses first and then
does the anycast addresses.
For IPv4, I'm not sure. The MS docs for GetIpAddrTable don't say, and I don't
have any systems where I could determine it experimentally.
-------------
PR: https://git.openjdk.org/jdk/pull/12593
