On Thu, 16 Feb 2023 11:09:30 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/components/ClassRemapper.java
> line 93:
>
>> 91:
>> 92: /**
>> 93: * ClassRemapper is a {@link jdk.internal.classfile.ClassTransform},
>> {@link jdk.internal.classfile.FieldTransform},
>
> Maybe wrap occurrences of `ClassRemapper` with `{@code}` (here and elsewhere)
will fix it, thanks.
> src/java.base/share/classes/jdk/internal/classfile/components/ClassRemapper.java
> line 168:
>
>> 166: public void accept(ClassBuilder clb, ClassElement cle) {
>> 167: switch (cle) {
>> 168: case FieldModel fm ->
>
> What about NestMembers, NestHost, PermittedSubclasses (and probably others) ?
Right, ClassRemapper is incomplete, will work on it.
> src/java.base/share/classes/jdk/internal/classfile/components/ClassRemapper.java
> line 306:
>
>> 304:
>> 305: ClassSignature mapClassSignature(ClassSignature signature) {
>> 306: return ClassSignature.of(signature.typeParameters(),
>
> Should type parameters also be mapped? (as they might have class bounds).
> Both here and in `mapMethodSignature`.
Nice catch, will fix it, thanks!
-------------
PR: https://git.openjdk.org/jdk/pull/10982
