On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov <dmar...@openjdk.org> wrote:
> Added the section devoted to client UI test which use Robot API doc/testing.md line 616: > 614: system key shortcuts for various platforms are provided below. > 615: > 616: ##### MacOS Suggestion: ##### macOS Shall we spell _macOS_ with lower-case ‘m’ like Apple does? doc/testing.md line 648: > 646: the default operating system settings need to be adjusted for correct > work of > 647: Robot functionality. The detailed steps how to access and update that > settings > 648: for different platforms are provided below. Suggestion: Most automated Client UI tests use `Robot` API to control the UI. Usually, the default operating system settings need to be adjusted for Robot to work correctly. The detailed steps how to access and update these settings for different platforms are provided below. doc/testing.md line 656: > 654: Privacy & Security; select Accessibility and ensure the following apps > are > 655: allowed to control your computer: `Java` and `Terminal`. If the tests > are run > 656: from an IDE, the IDE should be granted this permission too. Suggestion: `Robot` is not permitted to control your Mac by default since macOS 10.15. To enable it, choose Apple menu > System Settings, click Privacy & Security, then click Accessibility and ensure the following apps are allowed to control your computer: *Java* and *Terminal*. If the tests are run from an IDE, the IDE should be granted this permission too. I amended the instructions align with [Allow accessibility apps to access your Mac](https://support.apple.com/en-gb/guide/mac-help/mh43185/mac). Perhaps, “to allow it” is better than “to enable it”. Also unsure about “`Robot` is not *allowed* to control…” instead of “permitted”. *Java* and *Terminal* are the names of apps, not part of a command-line, therefore they're shouldn't be rendered in monospace font; using italics suits better to separate the names from regular text (even though it's not required). doc/testing.md line 664: > 662: select Registry Editor; navigate to the following key: > 663: `HKEY_CURRENT_USER\Control Panel\Desktop\ForegroundLockTimeout`; make > sure > 664: its value is set to 0. Suggestion: On Windows there is a delay in focus transfer. Usually it causes automated UI test failure. To disable the delay, type `regedit` in the Search and then select Registry Editor; navigate to the following key: `HKEY_CURRENT_USER\Control Panel\Desktop`; make sure the `ForegroundLockTimeout` value is set to 0. ------------- PR: https://git.openjdk.org/jdk/pull/12772
