The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent.
---------------------------------------------------------------------- On Tue, 25 Oct 2022 22:17:25 GMT, Erik Joelsson <er...@openjdk.org> wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Cleanup > > This looks like nice work. > > I'm curious how does this eclipse project figures out preprocessor settings > like -D flags from the build to correctly setup the environment for the > native code? I know this was a major deal when creating the > compile-commands.json for other native IDE integrations. I've heard some IDEs > just run the build once and inspect the command lines, but our default log > level won't show that. I'm not familiar with eclipse project files, but I > couldn't really see anything here that addressed this issue. Can you work > with the native code in a meaningful way without it? @erikj79 @magicus Seems like this is the best I can do for now, baseline support for Eclipse should now be present with these final touchups (Environment setup is not fully complete yet, but Eclipse is flexible enough that for most development work, this should not be too problematic). I do plan to refine support for it in the future, since there are still areas for improvement, but at present I think this should be decent enough for the time being ------------- PR: https://git.openjdk.org/jdk/pull/10853
