Re: RFR: 8295884: Implement IDE support for Eclipse [v38]

[Magnus Ihse Bursie]

On Mon, 6 Mar 2023 13:08:57 GMT, Julian Waters <jwat...@openjdk.org> wrote:

>> Eclipse is a popular and very well-known IDE in the world of Java 
>> development, utilized widely in many contexts, by beginners and experienced 
>> teams alike. Although a relatively lightweight IDE, it features surprisingly 
>> powerful indexing and code analysis capabilities, as well as useful tools, 
>> among which are make integration. While the tools it provides are not always 
>> as sophisticated as other IDEs (IntelliJ IDEA will likely come to mind as 
>> one such competitor), the simplicity of using it, as well as the reliability 
>> of this rugged IDE makes up greatly for the slightly less advanced tooling. 
>> Eclipse requires very little starting infrastructure in the workspace for 
>> all these features and indexing support as well, which makes it a good 
>> candidate for developing on the JDK.
>> 
>> This enhancement adds 4 extra targets to the make system for generating a 
>> basic Eclipse Workspace that provides almost full indexing support for the 
>> JDK, with varying levels as desired, from a minimalistic option only 
>> including the Java Virtual Machine's source code, to generating a workspace 
>> with both Java and C/C++ natures included, which allows for using Eclipse's 
>> unique ability to quickly swap between Java and C/C++ mode to work on both 
>> native and Java sources at the same time. Cross Compiling support is 
>> available, and in its entirety the change touches very little of the 
>> existing make system, barring its own Makefile within the ide subdirectory.
>> 
>> Indexing capabilities utilizing the enhancement:
>> <img width="960" alt="java" 
>> src="https://user-images.githubusercontent.com/32636402/197784819-67ec7de4-7e27-4f33-b738-59b75a9e4403.PNG";>
>> <img width="787" alt="escape" 
>> src="https://user-images.githubusercontent.com/32636402/197784843-df8621a8-7b0a-42da-86f4-3afb92de0f71.PNG";>
>
> Julian Waters has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Wording

make/ide/eclipse/workspace.template line 4:

> 2: <projectDescription>
> 3:     <name>Java</name>
> 4:     <comment>The official Java HotSpot Virtual Machine, Runtime 
> Environment, and Development Kit</comment>

Just call it OpenJDK; there is a legal trademark swamp associated with "Java".

make/ide/visualstudio/hotspot/CreateVSProject.gmk line 38:

> 36:   # able to extract flags, but we do not wish to execute the rules.
> 37: 
> 38:   # Use primary variant for defines and includes

This might be a correct fix but it is independent of this PR.

-------------

PR: https://git.openjdk.org/jdk/pull/10853