Thanks Erik! For the record, I found this while working on a micro benchmark experiment which was using some code from the test lib. Probably not something people do very often :-)
Eirik. On Thu, Mar 9, 2023 at 3:50 PM <erik.joels...@oracle.com> wrote: > Hello Eirik, > > While this target isn't often used (as can be seen from how far it's bit > rotted without anyone noticing), I think it's worth fixing it now that > you have identified the issues. There is some value in being able to > explicitly build these classes even if they are usually built by jtreg > as part of running tests. If you post a PR with this, I will review it. > > /Erik > > On 3/5/23 09:36, Eirik Bjørsnøs wrote: > > Hi, > > > > The 'build-test-lib' target seems to be broken: > > > > - make/test/BuildTestLib.gmk references the > > directory $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. > > This can be fixed by removing the reference. > > - Some test-lib sources use preview-features which is not enabled by > > make/test/BuildTestLib.gmk. This is fixed by adding a JAVAC_FLAGS with > > --enable-preview and also adding 'preview' to DISABLED_WARNINGS > > - ASN1Formatter.annotate has a possible lossy conversion from long to > > int which can be fixed by adding an explicit cast > > > > Let me know if this is worth fixing and I can create a PR from this > > branch of fixes: > > > > https://github.com/openjdk/jdk/compare/master...eirbjo:build-test-libs > > > > Thanks, > > Eirik. >
