On Mon, 13 Mar 2023 23:51:39 GMT, Phil Race <p...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updating.txt changes > > src/java.desktop/share/native/libharfbuzz/hb.hh line 107: > >> 105: #pragma GCC diagnostic warning "-Wformat=2" >> 106: #pragma GCC diagnostic warning "-Wformat-signedness" >> 107: #pragma GCC diagnostic warning "-Wignored-pragma-optimize" > > Reading these changes makes me think we should re-check if all the > DISABLED_WARNINGS we have for > harbuzz in Awt2DLibraries.gmk (see lines 466-470 in that file) are still > needed. > In particular for gcc + clang (ie windows and mac builds). > Can you comment them out (in that file) and test the build ? Any that are now > un-needed can be removed. @prrace Sure. I'll comment it out and check if there are any un-needed flags in DISABLED_WARNINGS section. ------------- PR: https://git.openjdk.org/jdk/pull/12913
