On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg <pminb...@openjdk.org> wrote:
> API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html src/java.base/share/classes/java/lang/foreign/AddressLayout.java line 59: > 57: */ > 58: @PreviewFeature(feature = PreviewFeature.Feature.FOREIGN) > 59: sealed public interface AddressLayout extends ValueLayout permits > ValueLayouts.OfAddressImpl { This should match other sealed interfaces: Suggestion: public sealed interface AddressLayout extends ValueLayout permits ValueLayouts.OfAddressImpl { src/java.base/share/classes/java/lang/foreign/Linker.java line 578: > 576: * Execution state is captured by a downcall method handle on > invocation, by writing it > 577: * to a native segment provided by the user to the downcall > method handle. > 578: * For this purpose, a downcall method handle linked with the > this Suggestion: * For this purpose, a downcall method handle linked with this ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1140677384 PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1140679387
