On Wed, 22 Mar 2023 16:21:51 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
>> Hi, >> >> Could I have a review of an enhancement that adds the option >> preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd >> JFR.configure. When set to true, chunk files in the repository will not be >> removed by the JVM at exit. >> >> Testing: jdk/jdk/jfr >> >> Thanks >> Erik > > Erik Gahlin has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Increase parameter count > - Merge branch 'master' of https://github.com/openjdk/jdk into keeponexit > - Fix whitespace > - Initial > - Initial Seems okay to me. Can't comment on the actual functionality. Thanks. test/jdk/jdk/jfr/jcmd/TestJcmdPreserveRepository.java line 2: > 1: /* > 2: * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights > reserved. New file should have new copyright - unless substantially copied (IIUC). ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13111#pullrequestreview-1353711980 PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1145581349
