On Thu, 23 Mar 2023 09:21:31 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Zdenek Zambersky has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Perform lib-test testing with debug builds > > .github/workflows/test.yml line 103: > >> 101: >> 102: - test-name: 'lib-test/tier1' >> 103: test-suite: 'test/lib-test/:tier1' > > I think this one should be executed with `debug` builds, like the Hotspot > testing? Because this touches some internal diagnostic interfaces, and thus > would benefit from checking the internal asserts hold. Should be enough to > add `debug-suffix` parameter here. fixed, thanks ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13063#discussion_r1147051138
