On Tue, 28 Mar 2023 10:56:07 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> API changes for the FFM API (third preview) >> >> Specdiff: >> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html >> >> Javadoc: >> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 22 commits: > > - Merge with master > - Make fallbacklinker.c consistent with downcallLinker.cpp > - Add bug number > - Use @return > - Update Linker.downcallHandle() javadoc > - Fix typos in Arena > - Make checking method handle zero case > - Add snippet to Linker.Option.captureStateLayout() > - Apply RISCV port patch > - Improve javadocs for Linker::captureStateLayout > - ... and 12 more: https://git.openjdk.org/jdk/compare/cddaf686...bc29c6fc src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 2310: > 2308: /** > 2309: * {@return {@code true}, if the provided object is also a > scope, which models the same lifetime as that > 2310: * modelled by this scope}. In that case, it is always the case > that This brace (after `scope`) seems spurious? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1150408522
