On Wed, 29 Mar 2023 10:14:49 GMT, Guoxiong Li <g...@openjdk.org> wrote:
> Hi all, > > This patch adds the RISC-V related content to `building.md`. But I didn't > generate `building.html` locally, because I know the `pandoc` version > may influencethe the output of `building.html` (Need help here). > > I know there are many steps and subtle points about cross-compiling the > external libraries. Considering the content length and the libraries are > introduced at `External Library Requirements`, I give only one example > instead of all of them. > > And I tried to build it by using `devkits` and `Debian sysroots`. But it > failed locally. > Maybe someone who has built successfully can tell me how to change the > document, which mainly adds the right name to their supported target table. > > Thanks for the review and assist. > > Best Regards, > -- Guoxiong Just some formatting and grammar notes. I can help you with running pandoc later. doc/building.md line 1233: > 1231: The RISC-V community provides a basic [GNU compiler > toolchain](https://github.com/riscv-collab/riscv-gnu-toolchain). > 1232: But the [external libraries](#External-Library-Requirements) required > by OpenJDK complicate the building process. > 1233: The placeholder `<toolchain-installed-path>` shown below is the path > you want to install the toolchain. Please keep paragraph text to 80 character width. "is the path you want" -> "is the path where you want" doc/building.md line 1246: > 1244: * Cross-compile all the required libraries: > 1245: ``` > 1246: # An example about libffi Suggestion: # An example for libffi ------------- PR Review: https://git.openjdk.org/jdk/pull/13223#pullrequestreview-1363124631 PR Review Comment: https://git.openjdk.org/jdk/pull/13223#discussion_r1151958166 PR Review Comment: https://git.openjdk.org/jdk/pull/13223#discussion_r1151955687
