On Thu, 30 Mar 2023 11:47:50 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for >> socket options such as ipDontFragmentSupported(), >> keepAliveOptionsSupported(), setTcpkeepAliveProbes, getTcpkeepAliveProbes, >> setQuickAck, getQuickAck and more, where it either returns false or >> exception. These options can be implemented on AIX with the supported flags >> like SO_PEERID, TCP_NODELAYACK is the equivalent AIX option for TCP_QUICKACK >> and IPPROTO_TCP, IP_DONTFRAG. >> >> - DontFragment test failure : >> >> DontFragmentTest.java fails with a runtime exception : “IP_DONTFRAGMENT >> should be supported” because the supportOptions doesn’t contain >> IP_DONTFRAGMENT flag. >> >> Reported Issue : [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089) > > make/modules/jdk.net/Lib.gmk line 30: > >> 28: >> ################################################################################ >> 29: >> 30: ifeq ($(call isTargetOs, linux macosx windows aix), true) > > Hello Varada, I'm not too familiar with these build files, but would this > change also require a `LIBS_aix := <relevant libs>` entry in this `eval` > block? Please update the copyright year on this file to `2016, 2023, ` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13240#discussion_r1153142315
