On Mon, 3 Apr 2023 09:36:39 GMT, David Holmes <[email protected]> wrote:
>> We have the strange situation where calling `t.isAlive()` on a
>> `java.lang.Thread` `t`, will call into the VM (via `alive()` then
>> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract
>> its `JavaThread` pointer and compare it to null. We can simply read `eetop`
>> directly in `Thread.alive()`:
>>
>> boolean alive() {
>> return eetop != 0;
>> }
>>
>> I also updated a comment in relation to `eetop`.
>>
>> Testing: tiers 1-3
>>
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Comment from AlanB
This looks interesting. I think it is time to rename `eetop` to
`javaThreadAddr` and comment that `javaThreadAddr != 0` means the thread has VM
thread attached, and thus alive. Probably hide that fields from reflection too,
like we do for some sensitive fields.
-------------
PR Review: https://git.openjdk.org/jdk/pull/13287#pullrequestreview-1368852869
