On Wed, 5 Apr 2023 08:19:32 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reformat comment block > > test/jdk/java/lang/Thread/IsAlive.java line 38: > >> 36: try { >> 37: while (!Thread.currentThread().isInterrupted()) { >> 38: Thread.sleep(10); > > Suggestion: > > Thread.sleep(100); Done > test/jdk/java/lang/Thread/IsAlive.java line 62: > >> 60: >> 61: if (!spinnerDone) { >> 62: throw new RuntimeException("last write of terminated thread >> wasn't seen!"); > > Suggestion: > > throw new RuntimeException("Last write of terminated thread was > not seen!"); Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13287#discussion_r1158200731 PR Review Comment: https://git.openjdk.org/jdk/pull/13287#discussion_r1158199923