On Fri, 14 Apr 2023 07:59:49 GMT, Varada M <d...@openjdk.org> wrote:
>> Breaking this into two parts :
>>
>> 1. Implementing socket options for AIX
>> 2. DontFragmentTest failure
>>
>> - Implementing socket options for AIX :
>>
>> Unlike the linux, windows and macOS, AIX uses the default implementation for
>> socket options such as ipDontFragmentSupported(),
>> keepAliveOptionsSupported(), setTcpkeepAliveProbes, getTcpkeepAliveProbes,
>> setQuickAck, getQuickAck and more, where it either returns false or
>> exception. These options can be implemented on AIX with the supported flags
>> like SO_PEERID, TCP_NODELAYACK is the equivalent AIX option for TCP_QUICKACK
>> and IPPROTO_TCP, IP_DONTFRAG.
>>
>> - DontFragment test failure :
>>
>> DontFragmentTest.java fails with a runtime exception : “IP_DONTFRAGMENT
>> should be supported” because the supportOptions doesn’t contain
>> IP_DONTFRAGMENT flag.
>>
>> Reported Issue : [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089)
>
> Varada M has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains six commits:
>
> - Merge branch 'master' into aix_socket_options
> - Updated copyright year
> - Update to copyright year
> - AIX socket options
> - aix socket options
> - AIX Socket Options
src/jdk.net/aix/native/libextnet/AIXSocketOptions.c line 130:
> 128:
> 129: if ((rv=getsockopt(fd, SOL_SOCKET, SO_PEERID, &cred_info, &len)) <
> 0) {
> 130: handleError(env, rv, "get failed");
Is the double space after "get " intended here, or is something missing from
the error message?
src/jdk.net/aix/native/libextnet/AIXSocketOptions.c line 133:
> 131: } else {
> 132: if ((int)cred_info.euid == -1) {
> 133: handleError(env, -1, "get failed");
Same here...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13240#discussion_r1166550875
PR Review Comment: https://git.openjdk.org/jdk/pull/13240#discussion_r1166551515
