On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang <li...@openjdk.org> wrote:
> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > comparison, `$1_MICRO_JAVA_OPTIONS += > --add-opens=java.base/java.io=ALL-UNNAMED` right above this patch seems to > work fine) > Also removed a useless and wrong Java flag to the java running javac, > originally intended to enable running `make test TEST="loom.obsolete"` > benchmarks. > > Since I only have a windows cygwin environment, I am not quite sure if this > works elsewhere. As I see, other places where java execution is used uses `$$(JAVA)` to extract the Java executable without fixpath. However, micro testing allows arbitrary JDK, which makes configuring the right path somewhat harder as a consequence, as it seems the build code to extract java executable is part of configure and there is no easily reusable code elsewhere. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13550#issuecomment-1516611508
