On Tue, 18 Apr 2023 05:58:08 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> The plugin which support execution of test's main method in separate virtual >> thread is added. >> The plugin is built as a part of test image and might be used in testing by >> adding JTREG_TEST_THREAD_FACTORY=Virtual option. > > I use `jtreg` standalone (outside of `make`) a lot of times to run tests. If > I understand the build changes correctly, `make images` will build the > necessary jars for the virtual thread factory class (does it require > `--with-jtreg` option to have been used during `configure`?). And then if I > want to use this `Virtual` thread factory, I can just do: > > > jtreg -testThreadFactoryPath:.... -testThreadFactory:... > > Is that right? > @jaikiran, Have I answered to all your questions? Thank you Lenoid for those details and updates to this PR. The latest changes look OK to me. I've added an inline comment about some typos in the `testing.md` documentation. Other than that this looks fine to me. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13432#issuecomment-1517144209
